add SEPROXYHAL_TAG_INVALID define#1456
Merged
mruiz-ledger merged 1 commit intomasterfrom Mar 16, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1456 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 37 37
Lines 4268 4268
Branches 522 522
=======================================
Hits 3920 3920
Misses 257 257
Partials 91 91
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a dedicated constant for an “invalid”/unset SEProxyHal tag value to the protocol header, aligning with the existing tag macro pattern and reserving 0x00 as an explicit sentinel.
Changes:
- Introduce
SEPROXYHAL_TAG_INVALIDdefined as0x00ininclude/seproxyhal_protocol.h.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jarevalo-ledger
approved these changes
Mar 11, 2026
mruiz-ledger
force-pushed
the
seproxyhal-protocol-tag
branch
from
3febf72 to
1f3d083
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a detailed description of what was done in this PR.
(And mention any links to an issue docs)
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it.
Additional comments
Please post additional comments in this section if you have them, otherwise delete it.
Auto cherry-pick in API_LEVEL
If requested to port the commits from this PR on a dedicated API_LEVEL branch,
select the targeted one(s), or add new references if not listed:
[ ] TARGET_API_LEVEL: API_LEVEL_25
This will only create the PR with cherry-picks, ready to be reviewed and merged.
Remember: